Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kickoff: Add watchdog for loop interactivity. #596

Merged
merged 11 commits into from
Aug 14, 2024
Merged

Kickoff: Add watchdog for loop interactivity. #596

merged 11 commits into from
Aug 14, 2024

Conversation

PremyslCerny
Copy link
Contributor

Discussed in Slack.

@PremyslCerny PremyslCerny self-assigned this Aug 8, 2024
mejroslav
mejroslav approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@mejroslav mejroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!

ateska
ateska requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@ateska ateska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be reasonable with the approach, this is a core of all microservices.

asab/application.py Outdated Show resolved Hide resolved
asab/application.py Outdated Show resolved Hide resolved
@PremyslCerny
Copy link
Contributor Author

I tested it with Correlator so far. It does not influence the init, run or exit time performance. Still, since it will influence or msvs, I would like to be more sure.

ateska
ateska requested changes Aug 8, 2024
View reviewed changes
asab/application.py Outdated Show resolved Hide resolved
asab/application.py Outdated Show resolved Hide resolved
asab/application.py Show resolved Hide resolved
@PremyslCerny PremyslCerny requested a review from ateska August 8, 2024 15:33
ateska
ateska requested changes Aug 8, 2024
View reviewed changes
asab/application.py Outdated Show resolved Hide resolved
ateska
ateska requested changes Aug 8, 2024
View reviewed changes
asab/application.py Outdated Show resolved Hide resolved
@mejroslav mejroslav self-requested a review August 9, 2024 08:11
@PremyslCerny
Copy link
Contributor Author

I will test it in Prima.

@PremyslCerny
Copy link
Contributor Author

@mejroslav Can you please test it with parsec if you have time? You should not observe any change.

@PremyslCerny PremyslCerny merged commit 6734a45 into master Aug 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejroslav mejroslav mejroslav approved these changes

@byewokko byewokko byewokko approved these changes

@ateska ateska ateska approved these changes

@eliska-n eliska-n Awaiting requested review from eliska-n

Assignees

@PremyslCerny PremyslCerny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PremyslCerny @ateska @byewokko @mejroslav