-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target info to "Library.change!" pubsub message #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ateska
requested changes
Aug 27, 2024
byewokko
commented
Aug 27, 2024
byewokko
changed the title
Set tenant context when publishing "Library.change!"
Add target info to "Library.change!" pubsub message
Aug 27, 2024
byewokko
commented
Aug 27, 2024
# Conflicts: # asab/library/providers/zookeeper.py
language-shprt
approved these changes
Sep 3, 2024
ateska
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LibraryService.subscribe
is extended with optionaltarget
argument.target
values:None
(default) or"global"
to watch global target changes,"tenant"
to watch changes in ANY tenant,("tenant", TENANT_ID)
to watch changes in a specific tenant.target
argument, whose value is either"global"
or("tenant", TENANT_ID)
.LibraryService.subscribe
is called withouttarget
argument (or its value isNone
), the callback is called withouttarget
argument.Other changes