Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work on windows #28

Closed
amirotin opened this issue Jan 24, 2022 · 1 comment
Closed

Doesn't work on windows #28

amirotin opened this issue Jan 24, 2022 · 1 comment
Assignees
@ateska
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@amirotin
Copy link

Hi!
There is no sys.getdlopenflags on winows, so entire package won't work here.

cysimdjson/cysimdjson/__init__.py

Line 7 in 3515a3a

prev = sys.getdlopenflags()

Better to add check for platform, something like sys.platform != 'win32'
@ateska
Copy link
Contributor

ateska commented Feb 12, 2022

Ok, good point.

@ateska ateska added bug Something isn't working good first issue Good for newcomers labels Feb 12, 2022
ateska added a commit that referenced this issue Mar 22, 2022
@ateska
Exclude the dynamic loading trick from Windows.
17ffb20 
Fix of #28
@ateska ateska self-assigned this Mar 22, 2022
@ateska ateska mentioned this issue Mar 22, 2022
Merged
@ateska ateska closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ateska ateska

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amirotin @ateska