resources actions #19

petrKavulok · 2023-02-09T15:13:49Z

related to

petrKavulok · 2023-02-13T05:57:30Z

czech translation in prompt not working

petrKavulok · 2023-02-23T07:07:06Z

Screen.Recording.2023-02-23.at.14.47.52.mp4

Pe5h4

@petrKavulok So far so good, minor updates request

Pe5h4 · 2023-05-03T07:55:30Z

public/locales/cs/translation.json

+	},
+	"ResourcesDeletedDetailContainer": {
+		"Resource": "Zdroj",
+		"Hard-delete": "Navždy odstranit",


@petrKavulok I would choose something like Trvale odstranit, it sounds better to me (just a subjective note)

Pe5h4 · 2023-05-03T07:56:39Z

public/locales/cs/translation.json

+		"Failed to hard-delete this resource": "Nepodařilo se navždy odstranit tento zdroj",
+		"Failed to retrieve resource": "Obnova zdroje se nezdařila",
+		"Resource retrieved successfuly": "Obnova zdroje proběhla úspěšně",
+		"Resource was successfully hard-deleted": "Zdroj byl úspěšně navždy odstranit",


@petrKavulok use trvale instead of navzdy

Pe5h4 · 2023-05-03T07:56:46Z

public/locales/cs/translation.json

+		"Hard-delete": "Navždy odstranit",
+		"Retrieve": "Obnovit zdroj",
+		"Can't fetch resource details": "Nepodařilo se načíst zdroj",
+		"Failed to hard-delete this resource": "Nepodařilo se navždy odstranit tento zdroj",


@petrKavulok use trvale instead of navzdy

Pe5h4 · 2023-05-03T07:56:58Z

public/locales/cs/translation.json

+		"Failed to retrieve resource": "Obnova zdroje se nezdařila",
+		"Resource retrieved successfuly": "Obnova zdroje proběhla úspěšně",
+		"Resource was successfully hard-deleted": "Zdroj byl úspěšně navždy odstranit",
+		"Do you really want to hard-delete this resource": "Opravdu si přejete navždy odstranit zdroj?",


@petrKavulok use trvale instead of navzdy

Pe5h4 · 2023-05-03T07:57:54Z

src/modules/auth/index.js

+			path: '/auth/resources-deleted',
+			exact: true,
+			name: 'Deleted resources',
+			component: ResourcesDeletedListContainer


@petrKavulok You should update your branch from main and then add a correct resource here

Pe5h4 · 2023-05-03T07:58:10Z

src/modules/auth/index.js

+			path: '/auth/resources-deleted/:resource_id',
+			exact: true,
+			name: 'Deleted resource detail',
+			component: DeletedResourceDetailContainer


@petrKavulok As per my comment above, add a correct resource

Pe5h4 · 2023-05-03T07:59:49Z

src/modules/auth/resources/DeletedResourceDetailContainer.js

+	const [editMode, setEditMode] = useState(false);
+	const { resource_id } = props.match.params;
+
+	const editResource = "authz:superuser";


@petrKavulok check the resources by the document on sharepoint and ask Robin, what resources should be implemented for any action we are providing to user regarding resources removal

Pe5h4 · 2023-05-03T08:02:12Z

src/modules/auth/resources/ResourcesDetailContainer.js

+						{editMode ?
+							<>
+								<ButtonGroup>
+										<Button color="primary" type="submit" >{t("Save")}</Button>


@petrKavulok I bet this button should be ButtonWithAuthz with some particular resource

Pe5h4 · 2023-05-03T08:02:46Z

src/modules/auth/resources/ResourcesDetailContainer.js

-									<i className="cil-code pr-2"></i>
-									JSON
+								<div className='actions-right'>
+									<Button color="danger" type="button" onClick={() => terminateResourceForm(resource._id)}>{t("ResourcesDetailContainer|Delete resource")}</Button>


@petrKavulok Again, this should be ButtonWithAuthz I suppose

Pe5h4 · 2023-05-03T08:03:49Z

src/modules/auth/resources/ResourcesListContainer.js

@@ -3,7 +3,7 @@ import { useTranslation } from 'react-i18next';
 import { useSelector } from 'react-redux';

 import { DataTable, ButtonWithAuthz } from 'asab-webui';
-import { Container } from 'reactstrap';
+import { Container, Button } from 'reactstrap';


@petrKavulok You dont use Button in the ResourcesListContainer, so it does not have to be loaded

Pe5h4 · 2023-05-12T07:42:56Z

src/modules/auth/resources/ResourcesDeletedListContainer.js

+	const [count, setCount] = useState(0);
+	const [page, setPage] = useState(1);
+	const [loading, setLoading] = useState(true);
+	const [show, setShow] = useState(false);


@petrKavulok I think this is not needed. I think its ok if the content loader appears only for a second. You are adding jsut too much logic to this considering we dont use it elsewhere. But if you want to do it this way, then we should update it in other parts of app.

In my subjective point of view, I think its enough to handle it just with loading state

Pe5h4 · 2023-05-12T07:43:16Z

src/modules/auth/resources/ResourcesDeletedListContainer.js

+
+	useEffect(()=>{
+		setShow(false);
+		if (resources.length === 0) {


@petrKavulok as my comment above

Pe5h4 · 2023-05-12T07:45:39Z

src/modules/auth/resources/ResourcesListContainer.js

@@ -19,6 +19,7 @@ function ResourcesListContainer(props) {
 	const ref = useRef(null);
 	const { t } = useTranslation();

+	const deleteResource = "seacat:resource:edit";


@petrKavulok do you really need it? take a look a line below, just use the resource on line 23, its the same

Pe5h4

@petrKavulok Just small renaming comment, otherwise it looks good from my point of view

Pe5h4 · 2023-05-22T21:18:57Z

src/modules/auth/index.js

+			exact: true,
+			name: 'Deleted resources',
+			component: ResourcesDeletedListContainer,
+			resource: 'seacat:resource:access'


@petrKavulok Clarify with @byewokko if this screen shouldnt be accessed only by superuser

@petrKavulok Then also other actions regarding hard deleting resource(s) will be only for superusers I guess (and not seacat:resource:edit)

Pe5h4 · 2023-05-22T21:19:12Z

src/modules/auth/index.js

+			exact: true,
+			name: 'Deleted resource detail',
+			component: DeletedResourceDetailContainer,
+			resource: 'seacat:resource:access'


@petrKavulok As per my comment above

Pe5h4 · 2023-05-22T21:21:49Z

src/modules/auth/resources/ResourcesDeletedListContainer.js

+	const ref = useRef(null);
+	const { t } = useTranslation();
+
+	const retrieveButtonResource = "seacat:resource:edit";


@petrKavulok Rename to retrieveResource - I think here its just fine

Pe5h4 · 2023-05-24T19:57:45Z

src/modules/auth/index.js

 		app.Router.addRoute({
 			path: '/auth/resources/:resource_id',
 			exact: true,
 			name: 'Resource detail',
 			component: ResourcesDetailContainer,
-			resource: "seacat:resource:access"
+			resource: "authz:superuser"


@petrKavulok Oh, this resource should have stayed as it was, please put it back

@Pe5h4 oh, right, sorry, my mistake

Pe5h4 · 2023-05-24T19:58:15Z

src/modules/auth/index.js

+			exact: true,
+			name: 'Deleted resources',
+			component: ResourcesDeletedListContainer,
+			resource: 'seacat:resource:access'


@petrKavulok This resource should be superuser

Pe5h4

Looks good!

delete resource button application

fb396c9

petrKavulok self-assigned this Feb 9, 2023

Petr Kavulok added 8 commits February 10, 2023 14:38

added routes for deleted resources

d8de6e0

locales update

cb99376

locales update and redirection

7cdd02c

locales update and redirection

93e88ce

init Deleted Detail container

99964c5

init Resources Deleted List container

a98bc25

translations update

ce6e329

locales update

077edd6

Petr Kavulok and others added 17 commits February 13, 2023 15:35

locales update for breadcrumbs and sidebar

d68a728

delete call params update

0641ec2

layout update

1c1209c

locales update

227afe1

Deleted resources sidebar item removal

a4fe456

deletedResourcesList button in ResourcesListContainer

2110bd2

adjustment of action buttons layout

33c4167

translations and Deleted Resources button in card header

63662f7

CHANGELOG.md update

f83dfb8

locales update

3c4ef18

translations update, obsolete code removal, button titles

7def9a5

go back button init, translations update, datatable icon update

ceba3b4

submodule update

ae1077e

locales update

0d4fe06

init retrive rerource prompt before the call

17fad9b

locales update

776a32c

translations update

a940a24

petrKavulok marked this pull request as ready for review February 23, 2023 07:07

petrKavulok added 3 commits April 26, 2023 10:00

get data for deleted resources list call update

a916cd2

obsolete code removal

fb29b67

DeletedResourceDetailConatiner naming update

3a48b81

petrKavulok requested a review from Pe5h4 April 26, 2023 09:45

Pe5h4 requested changes May 3, 2023

View reviewed changes

petrKavulok added 6 commits May 5, 2023 15:53

obsolete code removal

ad08c66

Merge branch 'main' into feature/resource-actions

e4ac584

access resource update

001a188

substituing regular buttons with ButtonWithAuthz

e48226d

locales udpate

29af2be

Button title update

814bddf

petrKavulok requested a review from Pe5h4 May 8, 2023 13:55

petrKavulok mentioned this pull request May 12, 2023

Deleting and renaming resources #1

Closed

4 tasks

Pe5h4 requested changes May 12, 2023

View reviewed changes

petrKavulok added 3 commits May 22, 2023 16:01

Merge branch 'main' into feature/resource-actions

e6fce0f

obsolete code removal - extra resource removal

65ac144

overengineered code removal - removal contentloader delay function

f611ae9

petrKavulok requested a review from Pe5h4 May 22, 2023 15:53

Pe5h4 requested changes May 22, 2023

View reviewed changes

petrKavulok added 4 commits May 23, 2023 11:31

resource update for DeletedResources routes in index.js

7d3bb13

naming update

46c20e4

Merge branch 'main' into feature/resource-actions

d0a9742

reosurce update

9b5ff19

petrKavulok requested a review from Pe5h4 May 24, 2023 09:17

Pe5h4 requested changes May 24, 2023

View reviewed changes

routes resources update

faf083e

petrKavulok requested a review from Pe5h4 May 25, 2023 11:52

Pe5h4 approved these changes May 25, 2023

View reviewed changes

petrKavulok merged commit a262085 into main May 26, 2023

petrKavulok deleted the feature/resource-actions branch May 26, 2023 07:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resources actions #19

resources actions #19

petrKavulok commented Feb 9, 2023 •

edited

Loading

petrKavulok commented Feb 13, 2023

petrKavulok commented Feb 23, 2023

Pe5h4 left a comment

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 3, 2023

Pe5h4 May 12, 2023

Pe5h4 May 12, 2023

Pe5h4 May 12, 2023

Pe5h4 May 12, 2023

Pe5h4 left a comment

Pe5h4 May 22, 2023

petrKavulok May 23, 2023

Pe5h4 May 23, 2023

Pe5h4 May 22, 2023

Pe5h4 May 22, 2023

Pe5h4 May 24, 2023

petrKavulok May 25, 2023 •

edited

Loading

Pe5h4 May 24, 2023

Pe5h4 left a comment

resources actions #19

resources actions #19

Conversation

petrKavulok commented Feb 9, 2023 • edited Loading

petrKavulok commented Feb 13, 2023

petrKavulok commented Feb 23, 2023

Pe5h4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pe5h4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petrKavulok May 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pe5h4 left a comment

Choose a reason for hiding this comment

petrKavulok commented Feb 9, 2023 •

edited

Loading

petrKavulok May 25, 2023 •

edited

Loading