Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump remove helmet #20

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Conversation

aringocode
Copy link
Collaborator

@aringocode aringocode commented Feb 24, 2023

Remove react-helmet form package.json

@aringocode aringocode self-assigned this Feb 24, 2023
@aringocode aringocode requested a review from Pe5h4 February 24, 2023 07:33
@@ -4,7 +4,7 @@

### Features

- ASAB WebUI submodule version bump [[7f3c1e5](https://github.com/TeskaLabs/asab-webui/commit/7f3c1e5e0c7513f69ad8653aef9f7e65ae635f29)] commit (INDIGO Sprint 230203, [!14](https://github.com/TeskaLabs/seacat-admin-webui/pull/14))
- ASAB WebUI submodule version bump [[a86c691](https://github.com/TeskaLabs/asab-webui/commit/a86c691689c71a6f65720e6f7e4f5f4fc65ef4d4)] commit (INDIGO Sprint 230217, [!20](https://github.com/TeskaLabs/seacat-admin-webui/pull/20))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aringoaway I miss information that react-helmet has been removed from the package.json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update before merging

@aringocode aringocode marked this pull request as ready for review February 24, 2023 10:32
@aringocode aringocode merged commit 529c9d8 into main Feb 24, 2023
@aringocode aringocode deleted the refactor/version-bump-remove-helmet branch February 24, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants