Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor phone and email in the body of the request #3

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

aringocode
Copy link
Collaborator

CredentialsCreateContainer: it will only send the field that is fulfilled
CredentialsDetailContainer: it will be sent null if a field that is not fulfilled

@aringocode aringocode requested a review from Pe5h4 November 14, 2022 08:09
@aringocode aringocode self-assigned this Nov 14, 2022
@aringocode
Copy link
Collaborator Author

@Pe5h4 Can you review pls? :)

credentials.mp4

Copy link
Collaborator

@Pe5h4 Pe5h4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aringoaway Ok, this should be fine

@aringocode aringocode marked this pull request as ready for review November 15, 2022 10:55
@aringocode aringocode merged commit 06bed2f into main Nov 15, 2022
@aringocode aringocode deleted the refactor/credentials-put-body branch November 15, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants