-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/BulkAssignment - Select all #47
Conversation
… Clear credentials selection button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petrKavulok Looks good, however I am not sure about the >
and <
in the cards (the button right next to the credential/tenant). When I see it it makes me a bit confused since I am not sure what those buttons are supposed to do. The +
and -
would be better
title={t("BulkAssignmentContainer|Select all displayed credentials")} | ||
disabled={allSelected} | ||
> | ||
<span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petrKavulok I dont think the span wrapper is necessary here
I agree with you, however these changes were requested, approved and blessed by Aleš |
Alrighty |
in this PR
Select all
button in Credentials Selection CardScreen.Recording.2023-07-07.at.10.28.12.mov