Refactor/replace dynamic locales #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
queuing4oranges
commented
Jul 6, 2023
queuing4oranges
commented
- updated asab-webui in seacat-auth-webui
- no changes in seacat-auth-webui/public/locales as there is no dynamic locales
- correction of double classname
petrKavulok
reviewed
Jul 6, 2023
CHANGELOG.md
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| ### Features | |||
|
|
|||
| - ASAB WebUI submodule version bump [[ae64c84](https://github.com/TeskaLabs/asab-webui/commit/ae64c84a78ecbbc32a1a02c5bf3bc196907b0263)] commit (INDIGO Sprint 230526, [!32](https://github.com/TeskaLabs/seacat-auth-webui/pull/32)) | |||
| - ASAB WebUI submodule version bump [[297aa81](https://github.com/TeskaLabs/asab-webui/commit/297aa819e97964aec33e03f545fc10819f0fe325)] commit (INDIGO Sprint 230623, [!37](https://github.com/TeskaLabs/seacat-auth-webui/pull/37)) | |||
There was a problem hiding this comment.
hmmms.. is this really the latest master version of asab-webui submodule?... 🤔
There was a problem hiding this comment.
@queuing4oranges Petr is right, please update the CHANGELOG and also asab webui submodule to this commit:
TeskaLabs/asab-webui@06af558
Pe5h4
requested changes
Jul 7, 2023
CHANGELOG.md
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| ### Features | |||
|
|
|||
| - ASAB WebUI submodule version bump [[ae64c84](https://github.com/TeskaLabs/asab-webui/commit/ae64c84a78ecbbc32a1a02c5bf3bc196907b0263)] commit (INDIGO Sprint 230526, [!32](https://github.com/TeskaLabs/seacat-auth-webui/pull/32)) | |||
| - ASAB WebUI submodule version bump [[297aa81](https://github.com/TeskaLabs/asab-webui/commit/297aa819e97964aec33e03f545fc10819f0fe325)] commit (INDIGO Sprint 230623, [!37](https://github.com/TeskaLabs/seacat-auth-webui/pull/37)) | |||
There was a problem hiding this comment.
@queuing4oranges Petr is right, please update the CHANGELOG and also asab webui submodule to this commit:
TeskaLabs/asab-webui@06af558
petrKavulok
reviewed
Jul 7, 2023
petrKavulok
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.