Refactor/penrose-background #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queuing4oranges
commented
Aug 8, 2023
| @@ -59,31 +53,6 @@ function LoginScreen(props) { | |||
| } | |||
| } | |||
|
|
|||
| function useWindowSize() { | |||
There was a problem hiding this comment.
the useWindowSize is only being used to measure and for re-creating background when screen size changes (same was in RegisterScreen)
it's now part of the generatePenrose function
Pe5h4
requested changes
Aug 11, 2023
| }, [size]) | ||
|
|
||
| return null; | ||
| } |
There was a problem hiding this comment.
@queuing4oranges No new line at the end of the file
ateska
approved these changes
Aug 11, 2023
|
Pe5h4
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatePenroseto all relevant screens"can't login" screen and resizing
seacat-auth-penrose-cant-login-screen-sizes.mp4
all screens
seacat-auth-penrose-all-screens.mp4
different browser /testing resizing
seacat-auth-penrose-screen-resizing-vivaldi.mp4