Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password criteria in new user registration form #44

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Password criteria in new user registration form #44

merged 12 commits into from
Jun 13, 2024

Conversation

byewokko
Copy link
Collaborator

follow-up from #43

Changes

  • New user registration form now also uses advanced password criteria loaded from the backend.
  • Created a new component PasswordChangeFieldGroup that is reused in Change password screen, Reset password screen and New user registration screen.

@byewokko byewokko added the enhancement New feature or request label Jun 11, 2024
@byewokko byewokko requested a review from Pe5h4 June 11, 2024 16:36
@byewokko byewokko self-assigned this Jun 11, 2024
@byewokko byewokko changed the title Password criteria in registration form Password criteria in new user registration form Jun 11, 2024
Pe5h4
Pe5h4 reviewed Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@Pe5h4 Pe5h4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK-ish, please reconsider the localization key refactorisation

public/locales/cs/translation.json Outdated Show resolved Hide resolved
@byewokko byewokko requested a review from Pe5h4 June 12, 2024 16:06
Pe5h4
Pe5h4 approved these changes Jun 13, 2024
View reviewed changes
src/modules/auth/containers/FormFields.js Outdated Show resolved Hide resolved
@byewokko byewokko merged commit a74c5b8 into main Jun 13, 2024
@byewokko byewokko deleted the feature/password-criteria-in-registration-form branch June 13, 2024 14:59
@byewokko byewokko mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pe5h4 Pe5h4 Pe5h4 approved these changes

Assignees

@byewokko byewokko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byewokko @Pe5h4