Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ES algorithms #118

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

swaeberle
Copy link
Contributor

See #117

Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
@swaeberle swaeberle force-pushed the feature/elliptic-curves branch from d8ab175 to e203dda Compare December 5, 2023 08:11
@swaeberle swaeberle marked this pull request as draft December 5, 2023 10:03
@swaeberle swaeberle marked this pull request as ready for review December 5, 2023 11:05
Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
@swaeberle swaeberle force-pushed the feature/elliptic-curves branch from 05e36ee to ed3e408 Compare December 5, 2023 12:30
Copy link
Contributor

@JoshMcCullough JoshMcCullough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Can you please add tests matching those for RS*?

@swaeberle
Copy link
Contributor Author

Thanks for this. Can you please add tests matching those for RS*?

I'll have a look on this, too!

Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
@swaeberle swaeberle force-pushed the feature/elliptic-curves branch from 675aa5e to 867a1c7 Compare December 6, 2023 10:33
Copy link
Contributor

@JoshMcCullough JoshMcCullough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. It's close -- make sure all instances of ES 512 are 512 and not 521.

@swaeberle
Copy link
Contributor Author

Sorry for the delay. It's close -- make sure all instances of ES 512 are 512 and not 521.

In fact the naming is no mixup but intended.

I used the elliptic curve NIST P-521 to create the keys with -521 suffix. Only later the key is used in combination with SHA-512 to form JWT algorithm ES512 (as defined by RFC 7518 section 3.4).

So the number originates from the named elliptic curve, not the hash function.

Though for the other JWT algorithms, named curve and hash function are equivalent.

@beeing
Copy link

beeing commented Mar 17, 2024

Hi, any resolution on this? I'm interested to use it with this too. Thanks in advance!

@swaeberle
Copy link
Contributor Author

swaeberle commented Mar 18, 2024

@JoshMcCullough Are you fine with keeping the test keys' file names or do you insist in renaming them?

@JoshMcCullough
Copy link
Contributor

@JoshMcCullough Are you fine with keeping the test keys' file names or do you insist in renaming them?

Thank you for clarifying -- my mistake.

@JoshMcCullough JoshMcCullough merged commit 032fa5c into TeslaGov:master Mar 18, 2024
@JoshMcCullough
Copy link
Contributor

@swaeberle swaeberle deleted the feature/elliptic-curves branch March 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants