-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for ES algorithms #118
add support for ES algorithms #118
Conversation
Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
d8ab175
to
e203dda
Compare
Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
05e36ee
to
ed3e408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Can you please add tests matching those for RS*?
I'll have a look on this, too! |
Signed-off-by: Stephan Wurm <stephan.wurm@a-eberle.de>
675aa5e
to
867a1c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. It's close -- make sure all instances of ES 512 are 512
and not 521
.
In fact the naming is no mixup but intended. I used the elliptic curve So the number originates from the named elliptic curve, not the hash function. Though for the other JWT algorithms, named curve and hash function are equivalent. |
Hi, any resolution on this? I'm interested to use it with this too. Thanks in advance! |
@JoshMcCullough Are you fine with keeping the test keys' file names or do you insist in renaming them? |
Thank you for clarifying -- my mistake. |
See #117