Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed mock file system exception when using root path as a parameter #1132

Merged
merged 9 commits into from
Jul 13, 2024
Merged

fix: fixed mock file system exception when using root path as a parameter #1132

merged 9 commits into from
Jul 13, 2024

Conversation

vladimir-shirmanov
Copy link
Contributor

@vladimir-shirmanov vladimir-shirmanov commented Jul 12, 2024 •
edited
Loading

fix: MockFileSystem does not support Root directories

Description

Added a check inside AddFile to be able to add new Drives within a constructor

Fixed #702

vbreuss
vbreuss reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@vbreuss vbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, I only have some minor suggestions.

Please also adapt the title to conform to the conventional commits guideline.

src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystem.cs Show resolved Hide resolved
tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileSystemTests.cs Show resolved Hide resolved
@vladimir-shirmanov
Copy link
Contributor Author

Thanks for the pull request, I only have some minor suggestions.

Please also adapt the title to conform to the conventional commits guideline.

oh sure, I'll add those in future commits.
Haven't seen that instruction in CONTRIBUTION.md, sorry for that.

vbreuss
vbreuss requested changes Jul 13, 2024
View reviewed changes
src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileSystem.cs Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@vladimir-shirmanov vladimir-shirmanov changed the title fixed mock file system exception when using root path as a parameter fix: changed mock file system exception when using root path as a parameter Jul 13, 2024
@vladimir-shirmanov vladimir-shirmanov changed the title fix: changed mock file system exception when using root path as a parameter fix: fixed mock file system exception when using root path as a parameter Jul 13, 2024
vbreuss
vbreuss approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@vbreuss vbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your effort, @vladimir-shirmanov 👍

vbreuss
vbreuss requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@vbreuss vbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just saw, that the tests failed for Ubuntu and MacOS. Probably the path separator must be OS dependent, @vladimir-shirmanov

@vladimir-shirmanov
Copy link
Contributor Author

Sorry, I just saw, that the tests failed for Ubuntu and MacOS. Probably the path separator must be OS dependent, @vladimir-shirmanov

I see that some tests are marked as Windows only, how do you think is it a good candidate for that as well?
Cause drives are Windows-only construct, so it is safe to mark those 2 specific tests as Windows only.

@vbreuss vbreuss merged commit f2bcaa9 into TestableIO:main Jul 13, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

This is addressed in release v21.0.26.

@github-actions github-actions bot added the state: released Issues that are released label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbreuss vbreuss vbreuss approved these changes

Assignees
No one assigned
Labels
state: released Issues that are released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MockFileSystem does not support Root directories
2 participants
@vladimir-shirmanov @vbreuss