Made FileSystemWatcher on MockFileSystem mockable#409
Merged
fgreinacher merged 10 commits intoTestableIO:masterfrom Dec 1, 2018
rkoeninger:mockable-watcher
Merged
Made FileSystemWatcher on MockFileSystem mockable#409fgreinacher merged 10 commits intoTestableIO:masterfrom rkoeninger:mockable-watcher
fgreinacher merged 10 commits intoTestableIO:masterfrom
rkoeninger:mockable-watcher
Conversation
Contributor
Author
|
@fgreinacher @jpreese @robkeim thoughts? |
robkeim
reviewed
Nov 30, 2018
System.IO.Abstractions.TestingHelpers.Tests/MockFileSystemWatcherFactoryTests.cs
Show resolved
Hide resolved
Contributor
|
@rkoeninger this change seems straight forward to me, I added one minor nit. |
Contributor
|
I’ll have a look today or tomorrow! |
fgreinacher
reviewed
Nov 30, 2018
System.IO.Abstractions.TestingHelpers/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
Contributor
|
One minor suggestion, otherwise this looks great! |
Co-Authored-By: rkoeninger <rkoeninger@att.net>
Contributor
|
Thanks @rkoeninger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
MockFileSystemWatcheras it doesn't do anything, isn't used and it would be confusing if client code attempted to test with it.MockFileSystemWatcherFactoryjust throwNotImplementedExceptionto make it clear there is no built-inMockFileSystemWatcher.MockFileSystem.FileSystemWatcher(of typeIFileSystemWatcherFactory) set-able so client code can provide its own mock implementation ofFileSystemWatcherBase.