Skip to content

feat: allow overriding properties of (Mock)FileSystem #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgreinacher merged 1 commit into from
Dec 22, 2021
Merged

feat: allow overriding properties of (Mock)FileSystem #782

fgreinacher merged 1 commit into from
Dec 22, 2021

Conversation

@fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Dec 22, 2021 •
edited
Loading

BREAKING CHANGES:

  • (Mock)FileSystem are now derived from a new public class FileSystemBase for symmetry with other types
  • The setter for MockFileSystem.FileSystemWatcher has been removed. It is now virtual and should be overriden if required.

Fixes #757
Fixes #778
Fixes #776

@fgreinacher
feat: allow overriding properties of (Mock)FileSystem
a54a8b3 
BREAKING CHANGES:
- (Mock)FileSystem are now derived from a new public class FileSystemBase for symmetry with other types
- The setter for MockFileSystem.FileSystemWatcher has been removed. It is now virtual and should be overriden if required.

Fixes #757, #778 and #776
@fgreinacher fgreinacher mentioned this pull request Dec 22, 2021
Closed
@fgreinacher fgreinacher merged commit 05486f7 into main Dec 22, 2021
@fgreinacher fgreinacher deleted the feat/allow-overriding-file-system-properties branch December 22, 2021 16:14
@github-actions
Copy link

github-actions bot commented Dec 22, 2021

This is addressed in release v16.0.1.

@github-actions github-actions bot added the state: released Issues that are released label Dec 22, 2021
@vbreuss vbreuss mentioned this pull request Aug 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

state: released Issues that are released

Projects

None yet

Milestone

No milestone

1 participant

@fgreinacher