feat: Add support for default values on stream creation #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birnsen
changed the title
Birnsen
force-pushed
the
feature/defaultAttributesForStreamCreation
branch
from
1dc0bad to
305395d
Compare
|
Looking at #861 I'm wondering whether we should set the timestamps by default. Did you try that? |
fgreinacher
reviewed
Jun 30, 2022
|
I realized that this "solution" is not the best one and look for a better one, where the timestamps are set at the proper locations. Thanks for your time. This PR can be closed. |
xtopaz
added a commit
to xtopaz/System.IO.Abstractions
that referenced
this pull request
Jul 2, 2022
This fixes setting of the appropriate timestamps in the MockFileData instances, when accessing them via the MockFileStream. This contains the implementation intended in TestableIO#860.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some tests we need the current
Datetimeand normalFileAttributesin order for the system under tests to work properly. This PR adds a new property to theMockFileSystemwhich initializes theMockFileDatawith the currentDatetimeandFileAttributesif needed.