refactor: fix sonar issues due to updated analyzers (#443) #284
build.yml
on: push
Test (MacOS)
5m 34s
Test (Ubuntu)
4m 15s
Test (Windows)
10m 18s
Test (.NET Framework)
5m 2s
Static code analysis
11m 33s
Test (Examples)
3m 11s
Upload coverage to Codacy
14s
Annotations
61 warnings
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L53
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L72
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L32
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L50
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetFileInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L16
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetFileInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Examples):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L34
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L53
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L72
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetPathCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetPathCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs#L53
The type argument string? from ExceptionTests.GetPathCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L16
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L34
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Ubuntu):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L63
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework)
The following actions uses node12 which is deprecated and will be forced to run on node16: darenm/Setup-VSTest@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L53
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L72
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetPathCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetPathCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs#L53
The type argument string? from ExceptionTests.GetPathCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L32
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L50
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (.NET Framework):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L16
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L16
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L53
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L34
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L63
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L72
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L82
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L50
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (MacOS):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L32
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L15
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L33
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L53
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs#L72
The type argument string? from ExceptionTests.GetDirectoryInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L32
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs#L50
The type argument string? from ExceptionTests.GetDriveInfoFactoryCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L16
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L34
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L63
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Test (Windows):
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs#L82
The type argument string? from ExceptionTests.GetDirectoryInfoCallbacks is nullable, while the type of the corresponding test method parameter paramName is not. Make the TheoryData type non-nullable, or make the test method parameter nullable. (https://xunit.net/xunit.analyzers/rules/xUnit1040)
|
Static code analysis:
Source/Testably.Abstractions.Interface/TimeSystem/ITimer.cs#L24
Either implement 'IDisposable.Dispose', or totally rename this method to prevent confusion. (https://rules.sonarsource.com/csharp/RSPEC-2953)
|
Static code analysis:
Source/Testably.Abstractions.Interface/Helpers/PathSystemBase.cs#L163
Make sure publicly writable directories are used safely here. (https://rules.sonarsource.com/csharp/RSPEC-5443)
|
Static code analysis:
Source/Testably.Abstractions.Interface/Helpers/PathSystemBase.cs#L159
'Path.GetTempFileName()' is insecure. Use 'Path.GetRandomFileName()' instead. (https://rules.sonarsource.com/csharp/RSPEC-5445)
|
Static code analysis:
Source/Testably.Abstractions.Interface/TimeSystem/ITimer.cs#L24
Either implement 'IDisposable.Dispose', or totally rename this method to prevent confusion. (https://rules.sonarsource.com/csharp/RSPEC-2953)
|
Static code analysis:
Source/Testably.Abstractions.Interface/Helpers/PathSystemBase.cs#L159
'Path.GetTempFileName()' is insecure. Use 'Path.GetRandomFileName()' instead. (https://rules.sonarsource.com/csharp/RSPEC-5445)
|
Static code analysis:
Source/Testably.Abstractions.Interface/Helpers/PathSystemBase.cs#L163
Make sure publicly writable directories are used safely here. (https://rules.sonarsource.com/csharp/RSPEC-5443)
|
Static code analysis:
Source/Testably.Abstractions.Interface/TimeSystem/ITimer.cs#L24
Either implement 'IDisposable.Dispose', or totally rename this method to prevent confusion. (https://rules.sonarsource.com/csharp/RSPEC-2953)
|
Static code analysis:
Source/Testably.Abstractions.Interface/Helpers/PathSystemBase.cs#L159
'Path.GetTempFileName()' is insecure. Use 'Path.GetRandomFileName()' instead. (https://rules.sonarsource.com/csharp/RSPEC-5445)
|
Static code analysis:
Source/Testably.Abstractions.Interface/Helpers/PathSystemBase.cs#L163
Make sure publicly writable directories are used safely here. (https://rules.sonarsource.com/csharp/RSPEC-5443)
|
Static code analysis:
Source/Testably.Abstractions.Interface/TimeSystem/ITimer.cs#L24
Either implement 'IDisposable.Dispose', or totally rename this method to prevent confusion. (https://rules.sonarsource.com/csharp/RSPEC-2953)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
Code coverage (MacOS)
Expired
|
726 KB |
|
Code coverage (Ubuntu)
Expired
|
725 KB |
|
Code coverage (Windows)
Expired
|
729 KB |
|