Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sonar issues #690

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: sonar issues #690

merged 3 commits into from
Dec 16, 2024

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Dec 16, 2024

Fix sonar issues detected after updating the build pipeline

@vbreuss vbreuss added the refactor A change or improvement without functional impact label Dec 16, 2024
@vbreuss vbreuss self-assigned this Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

Test Results

   46 files  ±0     46 suites  ±0   1m 46s ⏱️ -9s
3 156 tests ±0  3 116 ✅ ±0   40 💤 ±0  0 ❌ ±0 
8 747 runs  ±0  8 542 ✅ ±0  205 💤 ±0  0 ❌ ±0 

Results for commit aa53ad1. ± Comparison against base commit 77ff0ad.

This pull request removes 2376 and adds 2376 tests. Note that renamed tests count towards both.
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [143, 177, 82])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [160, 226, 162])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [181, 90, 152])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [182, 179, 224])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [187, 74, 250])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [200, 192, 246])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [245, 189, 106])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [250, 30, 207])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [52, 245, 229])
Testably.Abstractions.Testing.Tests.FileSystem.ChangeDescriptionTests ‑ ToString_ShouldIncludeChangeType(changeType: Created, fileSystemType: Directory, notifyFilters: FileName, path: "path082bbc89-2c01-4449-9632-4f17b7502ca3")
…
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [105, 21, 144])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [131, 4, 6])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [158, 155, 5])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [183, 244, 130])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [211, 205, 113])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [242, 99, 121])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [32, 97, 33])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [47, 218, 95])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [93, 188, 159])
Testably.Abstractions.Testing.Tests.FileSystem.ChangeDescriptionTests ‑ ToString_ShouldIncludeChangeType(changeType: Created, fileSystemType: Directory, notifyFilters: FileName, path: "path09091889-7ff2-4fd8-ab2b-20eac0d0715d")
…
This pull request removes 39 skipped tests and adds 39 skipped tests. Note that renamed tests count towards both.
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path5d487de2-b92a-4de2-9fd1-79a983705188")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathaa1730c4-d64d-4f38-8a39-216b6647cf88")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathd648ecbf-f300-45d3-9400-6d65238b3fe8")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathf96f33c6-5811-4fee-9863-8233a95819d3")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path67c6b211-bf93-4dcd-8265-160475105f0c", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "patha9437105-b882-4de0-a23d-cf408e061de7", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path103c7bae0-8f89-4f0d-abdf-b8030753c1bf", path2: "path222abacea-61a7-4d6f-b851-e6e1e2d356c2")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path12856a3c1-f879-4b49-8e24-63c100f32e9b", path2: "path227b4f481-f6fd-4609-874a-2d6cf043d8bc")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path171e67037-92e8-4393-9650-e5f661fca47e", path2: "path295587396-c50a-43fa-a88b-98ce82f7f730")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path183e0d346-f516-4f6d-b930-427780d6172c", path2: "path29b4995b5-edef-49be-9ddb-18b31231119e")
…
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path876428b9-d4bb-4166-8653-2ff2097e46c5")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path89812b6f-4a7a-48c8-8b96-583cd4f0cde2")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathaa5aacca-9a93-49d9-b37a-78cb6799aad8")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathd2f746bc-708d-4e34-83b8-ec633b3e4fad")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path0eb2ac06-2681-4a4f-a7c8-8ad526448252", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path875cae6a-085c-49f6-8ed5-18aec9547d4a", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path108d50c7e-8988-40fb-95e6-fbde149ada51", path2: "path2acf481e3-c0ea-4a34-a2db-882ddad8fffd")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path10fa891b5-f71b-47a3-8d14-7e506dc20cab", path2: "path26cd622bf-bfa1-4800-8574-1998814e434a")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path1104ea061-ef61-447d-b425-6d8dea8cf2c3", path2: "path258c7cc1d-d47e-47fa-a276-5f6106d8cf27")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path184dee517-ac15-4552-ad52-617248dfd712", path2: "path26a860d16-5534-4e9e-9245-413bfaef5aad")
…

♻️ This comment has been updated with latest results.

@vbreuss vbreuss force-pushed the topic/fix-sonar-issues branch from 8b915e0 to aa53ad1 Compare December 16, 2024 10:55
Copy link

sonarqubecloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss merged commit e855d61 into main Dec 16, 2024
15 checks passed
@vbreuss vbreuss deleted the topic/fix-sonar-issues branch December 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A change or improvement without functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant