refactor: only use reflection in FileSystemWatcherMock when simulating other OS
#871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FileSystemWatcherMock class to optimize performance by conditionally using reflection only when simulating non-native operating systems, rather than always using reflection for path manipulation.
Key Changes
- Conditional reflection usage based on simulation mode to improve performance in native scenarios
- Updated constructor parameters to use the
Pathproperty instead of local variables
Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs
Show resolved
Hide resolved
Source/Testably.Abstractions.Testing/FileSystem/FileSystemWatcherMock.cs
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
FileSystemWatcherMockclass to optimize performance by conditionally using reflection only when simulating non-native operating systems, rather than always using reflection for path manipulation.Key Changes
Pathproperty instead of local variables