fix: fix directory tests that fail on windows under certain conditions #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbreuss
approved these changes
Nov 8, 2025
Member
vbreuss
left a comment
vbreuss
left a comment
There was a problem hiding this comment.
Thanks, @seiben-dev for the fix!
|
This is addressed in release v5.0.0. |
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two tests that fail on Windows when the executing code is not located on the
D:drive.The fix is to change test setup code to initialize the
FileSystemwith the "drive unspecific" root path/instead of the drive specific root pathD:, so that theFileSystemis always initialized on the current drive.Fixes issue #888