[UIUC+ A&W SU23] Fixed flaky test in 'stleary/JSON-java' repository #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the changes. Please make sure your changes pass the format checker. https://github.com/TestingResearchIllinois/idoft/actions/runs/4539612864/jobs/8013444712?pr=744#step:6:13 You may need to capitalize Accepted. |
Contributing fix for flaky test 'testIndentComplicatedJsonObject' (#4899), 'testIndentSimpleJsonArray' (#4901), 'testIndentSimpleJsonObject' (#4902), PR is accepted.
|
Sorry for the ignorance, I've changed 'accepted' to 'Accepted', please check! |
superMaaax
changed the title
|
Thanks for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing fix for flaky test 'testIndentComplicatedJsonObject' (#4899), 'testIndentSimpleJsonArray' (#4901), 'testIndentSimpleJsonObject' (#4902), PR is accepted.
These three tests are fixed in 'stleary/JSON-java' repository.
Here is the stleary/JSON-java#734 that was accepted to fix the flaky test.
The following changes were made to pr-data.csv in this PR:
Flaky test 'testIndentComplicatedJsonObject', 'testIndentSimpleJsonArray', 'testIndentSimpleJsonObject' were already in pr-data.csv, I updated the line for these flaky tests to include the fix PR link and set the status to 'accepted.'