-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source control question #55
Comments
I'd say this is expected behavior. You normally do not want to add third-party libraries nor their static assets directly to your source control, at least if you are using nuget. Referencing them this way should work fine. |
Maybe, but I've never seen that warning before when using various NuGet packages on ASP.NET MVC projects. |
Let me know if you run into any problems other than the warning. There has been some packaging issues in the past, there is no detailed documentation from the blazor side on referencing static assets and how this should ideally work with nuget |
Thanks for the details! I've read up a tad on this and indeed, there has been some changes since preview7 that I missed on the subject. I simply need to move the files to wwwroot/_content and it should be ok. Or I should just remove it... In any case, this should certainly be adressed. Are you having any problems (runtime / publish-time) other than that annoying message and things looking weird? In the current implementation of the package the script file should not really be needed (it's packed inside the dll). Just trying to assess the emergency... :) |
No emergency yet. Haven't got to the point of trying to upload a file :) |
Wasn't as easy as I thought. I found out that the I'll have to rebuild the project incrementally to find out. |
Apparently it was my TypeScript build who added them. Ill fix this issue in the next release. THanks for your feedback. |
@Tewr Looks like it's not just your component that this issue. A colleague has added Blazorise to the app |
You are right, problem is still there in the latest release. I managed to figure out what the error was, but as I havent automated packaging I failed to account for it when building the package in the latest release. Next release should be ok... Thank you for tracking me on this issue or I would have missed it! Ideally I should create a test that verifies the package contents, but its a lot of work and I'm hoping it should stabilize now when approaching 3.0. |
Adding your package results in
but the files are actually located
so I get this message, and I can't add them to source control
I can ignore the warning obviously.
The text was updated successfully, but these errors were encountered: