Issue 1875: Hide search box filter. #1933
Conversation
… the admin list. This is the first solution described below that fully hides the "Search Box" from the filter list to avoid this confusion. The previous solution of hiding the "Search Box" is incomplete and still displays the "Search Box" in the "Disabled Filters" column. The "Search Box" is filtered out of the "Disabled Filters" by this commit. The following are the results of the investigation into this problem: The Search Box filter, when selected, gets saved to the database and returned to the UI on an appropriate `/submission-list/filter-columns-by-user` call. What is happening is that the Search Box is explicitly being removed from the filter list: - https://github.com/TexasDigitalLibrary/Vireo/blob/61fb5873989eee667951f7b80244fa4f91c084ea/src/main/webapp/app/controllers/submission/submissionListController.js#L150 And then later is handled differently as an "Excluded Column": - https://github.com/TexasDigitalLibrary/Vireo/blob/db2b4cacea96a29912138626fe1ed5985cb5d073/src/main/webapp/app/controllers/submission/submissionListController.js#L172 It appears to be originally added here with the exluded column: - TexasDigitalLibrary@c39ff04 - TexasDigitalLibrary#285 Vireo Slack messages relating to Search Box: - https://texas-digital-library.slack.com/archives/C7R78CADB/p1550676084006100 - https://texas-digital-library.slack.com/archives/C7R78CADB/p1682428409804819?thread_ts=1682428314.318099&cid=C7R78CADB - https://texas-digital-library.slack.com/archives/C7R78CADB/p1550696674010100 Referenced Github issues from the conversations: - TexasDigitalLibrary#1146
…-approach_1' into 1875-hide_search_filter
|
to clarify, if one clicks on the 'Customize Filters' link under 'Filter Options:' (not 'Now Filtering By:') and gets an intermodal popup, they will see 2 columns ('Displayed FIlters' and 'Disabled Filters'). Under the latter there used to be a search box and this fix merely has the code not searching for its input, correct? |
On the Admin List View, the This PR changes the modal popup to not even show the |
Resolves #1875
The Search Box filter was previously disabled/hidden but the filter was overlooked.
This helps finish the process by hiding the search box from the filter.