Refresh page after workflow uplaod to display new workflow #2915
+67
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
reviewed
Oct 9, 2024
core/gui/src/app/dashboard/component/user/user-workflow/user-workflow.component.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/dashboard/component/user/user-workflow/user-workflow.component.ts
Outdated
Show resolved
Hide resolved
bobbai00
approved these changes
Oct 11, 2024
core/gui/src/app/dashboard/component/user/user-workflow/user-workflow.component.ts
Outdated
Show resolved
Hide resolved
| ...this.searchResultsComponent.entries, | ||
| new DashboardEntry(uploadedWorkflow), | ||
| ]; | ||
| observer.next(); |
There was a problem hiding this comment.
when success, use notification service to log a successful message
There was a problem hiding this comment.
when success, use notification service to log a successful message
If I add 'this.notificationService.success("Upload Workflow Successful");' here, there will be two pop-up notifications after success. Should I move the notification from above to below?
core/gui/src/app/dashboard/component/user/user-workflow/user-workflow.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #2736
The user had to manually refresh the page after uploading a JSON workflow - the change is to automatically refresh
Changes
Invoke reload after uploading workflow.
Demo
Before
After