[Issue #246.1][Try #2] GUI: Add First Operator (regex) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
|
|
||
| <div class="dashboard" id="the-flowchart"> | ||
|
|
||
| <script src="js/onstart.js" type="text/javascript"></script> |
There was a problem hiding this comment.
Fix indentation here and throughout the HTML file.
| @@ -1,39 +1,58 @@ | |||
|
|
|||
There was a problem hiding this comment.
Fix all indentation in this js file and in the onstart.js file.
|
|
||
| @Author: Jimmy Wang | ||
| */ | ||
|
|
There was a problem hiding this comment.
Add a description to this function maybe.
|
|
||
| var operatorI = 0; | ||
|
|
||
| var defaultRegex = "zika\s*(virus|fever)"; |
There was a problem hiding this comment.
Constants should be named in upper case, and delimited by underscores. Like this -> DEFAULT_REGEX
|
Did a F2F review. After making a few changes made by @kishore-narendran please go ahead to do the merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Regex Operator -> Added Regex Panel in Menu
Added Delete Button
Added first Javascript interactions with flowchart.js ('createOperator' and 'deleteSelected')