Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting --hyperlinks via the RICH_HYPERLINKS environment variable #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andelink
Copy link

@andelink andelink commented Jul 31, 2022

Small commit to allow setting --hyperlinks via the RICH_HYPERLINKS environment variable, so users can export this in their shell rc file and always have hyperlinks enabled.

Kapture 2022-07-31 at 09 26 11

Corresponding issue:

@andelink
Copy link
Author

@willmcgugan here's the PR

Copy link

@harkabeeparolus harkabeeparolus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes and documentation look good to me!

I wouldn't personally submit a PR that bumps the version number, but other than that I see no problems. 😊

@andelink
Copy link
Author

Thanks @harkabeeparolus! Reason I bumped the version is to hopefully get a new release of the library, so I can install and begin using these changes 🙂

(Also, I don't have permissions to merge the changes since I don't have write access to the repo, so merging is in your hands.)

@andelink
Copy link
Author

@harkabeeparolus would a patch version update be more welcome?

- version = "1.8.0"
+ version = "1.8.1"

@harkabeeparolus
Copy link

@harkabeeparolus would a patch version update be more welcome?

I wouldn't know, I'm just a random pythonista on GitHub — I don't have any commit access either. 😊 I just don't think I'd personally make a PR with an included version bump. Unless it was specifically about assisting the maintainers with a new release. But maybe that's just me. 🤔

(I do believe minor version would be appropriate from a Semantic Versioning perspective, since patch versions are supposed to be bugfixes without new features.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants