Fix duplicate options #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_main.py
Outdated
| monkeypatch.setattr(click.decorators, "_param_memo", _param_memo_safe) | ||
|
|
||
| # import here (after monkeypatch) because decorators are run on import | ||
| from src.rich_cli.__main__ import main |
There was a problem hiding this comment.
This probably shouldn't import from a module called "src". I believe that running pytest with a src directory layout works best if you install pytest into your virtual environment. If you change the line to from rich_cli.__main__ import main then this works:
poetry install
poetry add --group dev pytest
poetry run pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By capitalizing the emoji single-letter option to
-J, a collision between JSON and emoji display options is removed.I also included a test that monkeypatches a private function of the
click.decoratorsmodule to make it fail noisily when option names are duplicated. Could be useful if CI is implemented for this project.Fixes #73