Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] @ breaks highlighting in hyperlinks #3327

Open
2 tasks done
plutonium-239 opened this issue Apr 10, 2024 · 1 comment
Open
2 tasks done

[BUG] @ breaks highlighting in hyperlinks #3327

plutonium-239 opened this issue Apr 10, 2024 · 1 comment
Labels
Needs triage

Comments

@plutonium-239
Copy link

plutonium-239 commented Apr 10, 2024 •
edited
Loading

Describe the bug

Hyperlinks containing an @ symbol are not properly highlighted.
It is a valid character used by multiple large websites (youtube and twitter should be enough of an example)

Screenshot with minimal code:
image

Expected: The whole link to be highlighted instead of just before the @

Platform

Click to expand

Windows 10, Windows Terminal v1.19, Python 3.8.6

python -m rich.diagnose
image
image

pip freeze | grep rich
rich==13.7.1
@github-actions GitHub Actions
Copy link

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

subrat-lima pushed a commit to subrat-lima/rich that referenced this issue Aug 15, 2024
Fix [BUG] @ breaks highlighting in hyperlink Textualize#3327
f591471 
Changes -
1. Added '@' in rich.highlighter:ReprHighlighter url regex pattern.
2. Added a test case in test_highlighter for the url with '@'.
@subrat-lima subrat-lima mentioned this issue Aug 15, 2024
Merged
9 tasks
willmcgugan added a commit that referenced this issue Aug 26, 2024
@willmcgugan
Merge pull request #3454 from subrat-lima/master
b6f2f7a 
Fix [BUG] @ breaks highlighting in hyperlink #3327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plutonium-239