task._progress change default_factory to create deque(maxlen=1000), t… #1926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o avoid run-time while loop to trim to length 1000
Type of changes
Checklist
Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.
Instead of explicitly looping over task._progress to trim down to 1000 items, declare _progress with a factory method
lambda: deque(maxlen=1000)
so that deque will do this work for you (presumably at C speed)No change needed for CONTRIBUTORS.md. No change to CHANGELOG.md since this change is not externally visible.