Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bold, dim, and reverse on legacy Windows consoles #2019

Merged
merged 7 commits into from
Mar 7, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Mar 3, 2022

Some fixes for the PR #1993

  • Adds support for bold, dim, and reverse on legacy Windows consoles.
  • Calls the Windows Console API in order to output text, instead of writing to the Console.file
  • More docstrings

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #2019 (81c4dc4) into ansi-to-win32 (7525377) will decrease coverage by 0.02%.
The diff coverage is 81.25%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ansi-to-win32    #2019      +/-   ##
=================================================
- Coverage          99.54%   99.52%   -0.03%     
=================================================
  Files                 73       73              
  Lines               7294     7310      +16     
=================================================
+ Hits                7261     7275      +14     
- Misses                33       35       +2     
Flag Coverage Δ
unittests 99.52% <81.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/console.py 99.63% <0.00%> (ø)
rich/_win32_console.py 90.00% <83.87%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7525377...81c4dc4. Read the comment docs.

@darrenburns darrenburns marked this pull request as ready for review March 3, 2022 16:20
@darrenburns darrenburns requested a review from willmcgugan March 3, 2022 16:20
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenburns darrenburns merged commit 9b76da2 into ansi-to-win32 Mar 7, 2022
@darrenburns darrenburns deleted the ansi-to-win32_pull-request-fixes branch March 7, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants