Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite loop in append #3480

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix infinite loop in append #3480

merged 2 commits into from
Sep 6, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Sep 6, 2024

Fixes #3479

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (9c74f03) to head (f44e8bd).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3480   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          74       74           
  Lines        8072     8072           
=======================================
  Hits         7931     7931           
  Misses        141      141           
Flag Coverage Δ
unittests 98.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmcgugan willmcgugan merged commit 22c2cff into master Sep 6, 2024
22 checks passed
@willmcgugan willmcgugan deleted the fix-infinite-append branch September 6, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Infinite loop in Text.append
2 participants