[Tree] Make TreeNode an immutable Sequence to allow for walking the tree #1398
Assignees
Labels
enhancement
New feature or request
Comments
|
👍 I just needed this for writing code that "focuses" the tree on a specific node, collapsing all nodes other than one specific node. In my use-case I get only the names of the nodes (labels), not the nodes themselves, along them path; so have to traverse children. |
|
Making the list public invites a few problems. A dev might expect to be able to extend, remove etc and the tree to update accordingly. I think we should provide for the use-case of iterating children, and walking a sub-tree without exposing the list. |
|
I'm thinking perhaps we should make TreeNode a Sequence, to allow for iterating. This would allow for walking a tree while not exposing internals. |
willmcgugan
changed the title
children a public property of a TreeNode
willmcgugan
changed the title
davep
changed the title
davep
added a commit
to davep/textual
that referenced
this issue
Jan 5, 2023
In anticipation of satisfying Textualize#1398, this adds a generic immutable sequence wrapper class. The idea being that it can be used to wrap up a list or similar, that you don't want the caller to modify. This commit aims to get the basics down for this, and also adds a minimal set of unit tests.
davep
added a commit
to davep/textual
that referenced
this issue
Jan 5, 2023
|
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
rodrigogiraoserrao
pushed a commit
that referenced
this issue
Jan 7, 2023
In anticipation of satisfying #1398, this adds a generic immutable sequence wrapper class. The idea being that it can be used to wrap up a list or similar, that you don't want the caller to modify. This commit aims to get the basics down for this, and also adds a minimal set of unit tests.
rodrigogiraoserrao
pushed a commit
that referenced
this issue
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Especially to allow some initial "just so" setup of a
Tree, but also to make it easy to write code to walk aTree, it would be useful to have public access to thechildrenof aTreeNode.The text was updated successfully, but these errors were encountered: