ProgressBar: decrease CPU consumption by adjusting Bar.auto_refresh when styles.display is None

[xavierog]

Overall, ProgressBar is not a CPU-greedy widget. It does bring a small yet noticeable increase in CPU consumption when left in "indeterminate" mode since this mode involves a sliding animation. As far as I can tell, this is both normal and acceptable.

However, I noticed this CPU consumption does not decrease when the progress bar is hidden (e.g. self.progress_bar.styles.display = 'none'). This could be improved by adjusting Bar.auto_refresh whenever necessary.

Currently, Bar.auto_refresh only reacts to changes of the percentage attribute:

textual/src/textual/widgets/_progress_bar.py

Lines 90 to 95 in fd36937

	def watch_percentage(self, percentage: float | None) -> None:
	"""Manage the timer that enables the indeterminate bar animation."""
	if percentage is not None:
	self.auto_refresh = None
	else:
	self.auto_refresh = 1 / 15

[github-actions]

We found the following entry in the FAQ which you may find helpful:

• How do I center a widget in a screen?

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

[willmcgugan]

Good point. It probably makes sense for the auto_refresh feature to check if the widget is actually visible before refreshing. Should be a trivial change.

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.