More input bindings #1676
Merged
More input bindings #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl+A and Ctrl+E See Textualize#1310.
That is, delete deletes the character to the right -- the opposite of backspace if you will. See Textualize#1310.
And in doing so bind it to Ctrl+K (macOS/Emacs/readline-common). Right now I'm not aware of a common combo for this on Windows, but we can add a binding for this if one becomes apparent. See Textualize#1310.
And in doing so bind it to Ctrl+U (readline-common). Right now I'm not aware of a common combo for this on Windows, but we can add a binding for this if one becomes apparent. See Textualize#1310.
This makes no difference to anything; but I think it makes for code that's easier on the eye so someone scanning down the list of bindings will see the more descriptive key first. See Textualize#1310.
This makes no difference to anything; but I think grouping the bindings into similar groups will make it easier for folk to read and find things. See Textualize#1310.
Don't focus on home/end and things like that, and also try and keep all of the related names related.
I'm going to be adding more tests for Input, and I don't want to be doing one large monolithic file of them, so this makes a space where Input-targeting tests can live together and be easy to spot.
This is just getting a feel for how I'll go about testing these. The main focus here won't be on the bindings themselves -- they're not really interesting and I feel could change over time anyway as people's tastes settle down. What I want to test here are the actions that get bound. This is just an initial small set of what's going to be a much bigger collection of Input action tests.
This should result in a NOP.
There are actions that relate to editing the input too, which I also want to test, but I'm not minded to lump them all in the same file. So here I'm renaming to make it clear these tests are just about movement. The editing ones will come next in their own file.
This time all the things to do with deleting right.
willmcgugan
approved these changes
Jan 30, 2023
davep
added a commit
to davep/textual
that referenced
this pull request
Jan 30, 2023
The idea here is that a password field should give no hint as to what's within, length notwithstanding. To this end have the actions that (re)move based on word boundaries act as if a password field is always just one word. See Textualize#1692 (and previously Textualize#1676, prompted originally by Textualize#1310).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #1310, this PR adds additional bindings to the
Inputwidget, and also expands onInput-related unit tests, concentrating on testing the effects of movement and (non-character-input) editing actions.The actions added to
Inputare:Additional common bindings have been added too; these include:
The additions are generally either those that are common at the OS level on macOS (if similar key combinations are common at the OS level on other operating systems, do please mention them and/or add them -- note here we're looking at specific key combinations, not "mark and then delete" type operations), or which were suggested in #1310.
Where sensible docstrings have been added to pre-existing actions that were previously lacking them.