Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight top item #5361

Merged
merged 3 commits into from
Dec 8, 2024
Merged

highlight top item #5361

merged 3 commits into from
Dec 8, 2024

Conversation

willmcgugan
Copy link
Collaborator

Selects the first item in the command palette when the search is updated.

Previously the first item would be selected if you hit return, but there was no visual indicator of this. Even knowing this, I would find myself hitting down then return, when return would suffice.

I chose the blurred style for the option list since the Input is where the action happens.

Screen.Recording.2024-12-08.at.15.34.54.mov

@willmcgugan
Copy link
Collaborator Author

@darrenburns I think we have a conversation about this a while back. This feels way more intuitive to me now. WDYT?

@willmcgugan
Copy link
Collaborator Author

#executivedecision

@willmcgugan willmcgugan merged commit aef7c9e into main Dec 8, 2024
8 of 9 checks passed
@willmcgugan willmcgugan deleted the command-palette-highlight branch December 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant