boost for first letter matches #5365
Conversation
src/textual/fuzzy.py
Outdated
| @@ -40,6 +40,10 @@ def __init__( | |||
| ".*?".join(f"({escape(character)})" for character in query), | |||
| flags=0 if case_sensitive else IGNORECASE, | |||
| ) | |||
| self._first_word_regex = compile( | |||
There was a problem hiding this comment.
Is a new Matcher created on each key press in the command palette？
|
Actually, I've nerd sniped myself. We can do so much better with the matching, but regexes aren't going to be enough. |
|
Putting this on hold. I'm going to show great strength of character and not work on this, because there are higher priorities right now. |
|
@willmcgugan Do you want to merge this to get the improvement in or stick with what we have? |
|
Going to hold off merging this. It's not quite a 100% improvement. |
|
@darrenburns slept on it, and came up with this. You may want to check it against Posting. |
|
Cool - I'll try it against Posting soon. |
|
Minor but these look the wrong way around: 
Should the first Also I'm not sure about underlining the spaces. |
|
The current highlighting is the best score. The way it is highlighted includes the You can match spaces, but I agree not highlighting them would be better. |
|
Wait, I see what you mean. It could match I may be able to tweak the heuristic. ATM it gives a boost to single words. It could boost based on the least number of groups. |
|
@darrenburns tweaked the heuristic so it favors matches with fewer groups. |
|
I'm not sure that was the problem as in the original example wasn't there 4 matching groups in both results? It still seems like the first 
|
|
My estimate for a reasonable maximum on the number of loops was too low. Seems to work well with your example now. "exp res" puts response at the top. |
Tweak to the command palette matcher to boost matches for the first word(s).
Consider the system commands. If I were to type "SS" I would get "Show Keys and Help Panel". Now I get "Save Screenshot" because I'm matching the first letters.
Knowing this makes it easier to get a precise match.