-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- We recently let a couple of issues slip through code review becase we don't lint our podspec on pull requests since the task takes too long (about half an hour). To prevent this from happening again, this PR adds 2 new CI jobs that lint default and other subspecs on all PRs. By splitting into 2 tasks, the impact on total CI time should be mitigated somewhat. There is still a master-only task that lint all subspecs as the last line of defense in case the 2 new tasks miss any.
- Loading branch information
Showing
3 changed files
with
54 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
name: CI (pull-requests-only jobs) | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
buildsh: | ||
env: | ||
DEVELOPER_DIR: /Applications/Xcode_11.app/Contents/Developer | ||
strategy: | ||
matrix: | ||
mode: [cocoapods-lint-default-subspecs, cocoapods-lint-other-subspecs] | ||
include: | ||
- mode: cocoapods-lint-default-subspecs | ||
name: Verify that default subspecs lint | ||
- mode: cocoapods-lint-other-subspecs | ||
name: Verify that other subspecs lint | ||
name: ${{ matrix.name }} | ||
runs-on: macOS-latest | ||
steps: | ||
- name: Checkout the Git repository | ||
uses: actions/checkout@v1 | ||
- name: Run build script | ||
run: ./build.sh ${{ matrix.mode }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters