Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for rounding corners within Texture #trivial #1044

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Add documentation for rounding corners within Texture #trivial #1044

merged 1 commit into from
Jul 25, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Jul 23, 2018

No description provided.

Adlai-Holler
Adlai-Holler reviewed Jul 23, 2018
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just GitHub's viewer but the language-switcher code doesn't seem to render as expected:

screen shot 2018-07-23 at 9 52 53 am

@maicki
Copy link
Contributor Author

maicki commented Jul 25, 2018

@Adlai-Holler That should be just a Github issue. I ran the docs locally via Jekyll and there it looked fine.

garrettmoon
garrettmoon approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @maicki !

@maicki maicki merged commit 4880b54 into master Jul 25, 2018
@maicki maicki deleted the MSRoundedCornerDocumentation branch July 29, 2018 15:31
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@maicki @mikezucc
Add documentation for rounding corners within Texture (TextureGroup#1044
18b7c34 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adlai-Holler Adlai-Holler Adlai-Holler left review comments

@garrettmoon garrettmoon garrettmoon approved these changes

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maicki @garrettmoon @Adlai-Holler