-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layer backed nodes not update properly #1110
Fix layer backed nodes not update properly #1110
Conversation
This reverts commit 06e18a1.
Layers can be thrashed by UIKit with (exit then enter) during push/pop view controller or reload cells. |
🚫 CI failed with log |
[self._locked_asyncLayer cancelAsyncDisplay]; | ||
|
||
// Don't call -didExitHierarchy while holding __instanceLock__. | ||
// Don't call -didExitHierarchy while holding __instanceLock__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add space to trigger CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems right! Later on, we should see if we can eliminate the "schedule display on enter hierarchy" behavior and make that rely on interface state too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me.
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Do not cancel on exit, interface state update should handle it. * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * add space to trigger ci * add change log
No description provided.