-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default tuning params #1158
Merged
Adlai-Holler
merged 38 commits into
TextureGroup:master
from
wsdwsd0829:set-default-tuning-params
Oct 10, 2018
Merged
Changes from 32 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
929d118
fix SIMULATE_WEB_RESPONSE not imported #449
wsdwsd0829 dd24d8f
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 b8eaffa
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 2918ea0
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 9c42266
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 329f35f
Fix to make rangeMode update in right time
wsdwsd0829 5f8b7ec
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 d87bb11
merge master from upstream
wsdwsd0829 269c2ab
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 24c1ce8
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 233169e
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 b19f90d
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 b50cec4
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 b75a5f3
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 64b46e0
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 5fabc1e
remove uncessary assert
wsdwsd0829 3d5b84b
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 098b978
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 77eefd6
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 0310ed7
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 0b886de
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 a63d438
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 06e18a1
Fix collection cell editing bug for iOS 9 & 10
wsdwsd0829 918434d
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 41d3680
Revert "Fix collection cell editing bug for iOS 9 & 10"
wsdwsd0829 34833a3
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 8d82d21
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 91d6c46
Only test when photo library is enabled.
wsdwsd0829 e397bfc
Add ChangeLog.
wsdwsd0829 2e09fc0
set default tuning parameters for collection/table node
wsdwsd0829 f02d47c
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 d2d5afd
Merge branch 'master' into set-default-tuning-params
wsdwsd0829 08a4e70
add change log
wsdwsd0829 7c4c529
Move to framework private.
wsdwsd0829 9575d92
Apply to tableNode
wsdwsd0829 7ed9ebe
trigger ci
wsdwsd0829 f878da2
fix directory
wsdwsd0829 31f3be6
fix file link
wsdwsd0829 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a public header, I'm a bit worried about exposing Obj-C++ here since it's going to cause a cascade effect on every header file that imports it and every impl file that imports any of these headers. We're already seeing the effect in this PR.
How about we expose a Obj-C method here that converts the Obj-C data structure into a vector? Then maybe expose this Obj-C++ version in a framework private header, in case we want to mitigate any perf concern regarding the conversion.How about exposing this Obj-C++ method in a framework private header?