Remove unused headers #1615
Merged
Remove unused headers #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hanton
commented
Aug 14, 2019
hanton
commented
- Improve compilation time by reducing unnecessary compilation dependencies
- More clean code
|
🚫 CI failed with log |
|
Agree that we should remove unused imports. CI is failing though, can you take a look? |
hanton
force-pushed
the
remove_unused_headers
branch
from
ad7d823
to
2b882a0
Compare
* Improve compilation time by reducing unnecessary compilation dependencies * More clean code
hanton
force-pushed
the
remove_unused_headers
branch
from
2b882a0
to
87179b3
Compare
Fixed @nguyenhuy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.