Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to tint color support #1620

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

nguyenhuy
Copy link
Member

@nguyenhuy nguyenhuy commented Aug 15, 2019

Quick follow up on #1617:

  • Need to assert thread affinity in the getter when the node is view-backed and loaded. This is because UIView properties can't be accessed off main thread.
  • When the node is view-backed, we shouldn't ascend the node hierarchy. UIView should already ascend the view hierarchy and we currently don't support adding a view-backed node as a subnode of a layer-backed node (the other way around is fine).
  • _getFromViewOnly and _setToViewOnly check if the node loaded and do the right thing. So by checking layerBacked first, we can use them and simplify our getter and setter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants