[GitHub CI] Add step to block PRs from forked repositories unless they have the right label #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will the "label" action re-kick-off the failed build? |
|
It should according to the doc:
https://help.github.com/en/articles/events-that-trigger-workflows#webhook-events |
nguyenhuy
force-pushed
the
HN-Actions-PRs
branch
7 times, most recently
from
dfe1d94
to
39ceaf6
Compare
nguyenhuy
force-pushed
the
HN-Actions-PRs
branch
from
39ceaf6
to
4808f6a
Compare
nguyenhuy
force-pushed
the
HN-Actions-PRs
branch
from
4808f6a
to
61e32e6
Compare
|
🚫 CI failed with log |
nguyenhuy
force-pushed
the
HN-Actions-PRs
branch
from
35a53ac
to
ef0e70b
Compare
nguyenhuy
force-pushed
the
HN-Actions-PRs
branch
from
ef0e70b
to
19e8d76
Compare
nguyenhuy
changed the title
|
@jparise This is ready for review if you have a minute! |
|
Thank you! |
nguyenhuy
added a commit
to nguyenhuy/Texture
that referenced
this pull request
Aug 21, 2019
In TextureGroup#1627 I introduced an approval step that is meant to block PRs from forked repos unless they're labeled as "CI approved" by a maintainer. Turned out it doesn't work. When a label is added, a pull_request event with "labeled" as its action is fired but GitHub CI didn't restart the workflow. My guess is it checked the PR's commit and branch and determined that nothing has changed. Here is what the doc says: "A workflow runs on a specific version of code in your repository, determined by the commit SHA and Git ref" (https://help.github.com/en/articles/events-that-trigger-workflows#webhook-events). This diff removes the label check so all PRs are automatically built. Here are the current usage limits in case we run into them: https://help.github.com/en/articles/workflow-syntax-for-github-actions#usage-limits
nguyenhuy
added a commit
that referenced
this pull request
Aug 21, 2019
In #1627 I introduced an approval step that is meant to block PRs from forked repos unless they're labeled as "CI approved" by a maintainer. Turned out it doesn't work. When a label is added, a pull_request event with "labeled" as its action is fired but GitHub CI didn't restart the workflow. My guess is it checked the PR's commit and branch and determined that nothing has changed. Here is what the doc says: "A workflow runs on a specific version of code in your repository, determined by the commit SHA and Git ref" (https://help.github.com/en/articles/events-that-trigger-workflows#webhook-events). This diff removes the label check so all PRs are automatically built. Here are the current usage limits in case we run into them: https://help.github.com/en/articles/workflow-syntax-for-github-actions#usage-limits
matthewd1234
pushed a commit
to matthewd1234/Texture
that referenced
this pull request
Aug 25, 2019
…y have the right label (TextureGroup#1627) Block pull requests from forked repositories that aren't from, and aren't labeled by, a maintainer. Adding "CI approved" label will unblock them.
matthewd1234
pushed a commit
to matthewd1234/Texture
that referenced
this pull request
Aug 25, 2019
In TextureGroup#1627 I introduced an approval step that is meant to block PRs from forked repos unless they're labeled as "CI approved" by a maintainer. Turned out it doesn't work. When a label is added, a pull_request event with "labeled" as its action is fired but GitHub CI didn't restart the workflow. My guess is it checked the PR's commit and branch and determined that nothing has changed. Here is what the doc says: "A workflow runs on a specific version of code in your repository, determined by the commit SHA and Git ref" (https://help.github.com/en/articles/events-that-trigger-workflows#webhook-events). This diff removes the label check so all PRs are automatically built. Here are the current usage limits in case we run into them: https://help.github.com/en/articles/workflow-syntax-for-github-actions#usage-limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block pull requests from forked repositories that aren't from, and aren't labeled by, a maintainer.