[ASCollectionNode] Fix missing properties and layoutInspector #trivial #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Generated by 🚫 Danger |
Adlai-Holler
approved these changes
May 26, 2017
There was a problem hiding this comment.
As always, this is an absolutely killer diff @flovouin. Clean and functional. Thanks! Either add #trivial or update the CHANGELOG to give yourself credit, and then we'll land this guy.
flovouin
changed the title
|
Thanks! As this is not a new feature but a straightforward bug fix, I'm marking it as trivial. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
TextureGroup#305) * [ASCollectionNode] Set the layoutInspector from the pendingState in didLoad. * [ASCollectionNode] Forward scroll properties from the view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
Some
ASCollectionViewproperties have recently been deprecated in favour of theirASCollectionNodecounterparts, but it turns out that they're not fully functional yet:layoutInspectorfrom the_pendingStateis not forwarded to the view indidLoad, which means that setting it only works after the view has been loaded, which kinda defeats the purpose of having the property at the node level.scrollDirectionandscrollableDirectionsproperties are not implemented, which means that we never get the actual value from the underlying view.These two problems are demonstrated in this sample project (along with a waterfall layout that could be useful to some Texture users :-)): https://github.com/flovouin/Texture-CollectionNodeProperties
The
layoutInspectorfix is rather straightforward. However concerning the property forwarding, I'm not entirely sure what the guidelines are. I just made sure not to load the view needlessly, but you might have a better way to do that. Please tell me and I'll update the PR ASAP if needed.Cheers,
Flo