Add support for keeping letting cell nodes update to new view models when reloaded. #trivial #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
changed the title
nguyenhuy
approved these changes
Jun 13, 2017
| @@ -182,21 +222,70 @@ - (void)assertCollectionNodeContent | |||
| * Updates the collection node, with expectations and assertions about the call-order and the correctness of the | |||
| * new data. You should update the data source _before_ calling this method. | |||
| * | |||
| * invalidatedIndexPaths are the items we expect to get refetched (reloaded/inserted). | |||
| * indexPathsForPreservedNodes are the old index paths for nodes that should use -canUpdateToViewModel: instead of being refetched. | |||
There was a problem hiding this comment.
You mean skippedReloadIndexPaths?
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…when reloaded. #trivial (TextureGroup#357) * Add support for skipping reload if node decides it is compatible with new view model also * Sort things right * Put the order back * No need for redundant expectation * Fix license header * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-(BOOL)[ASCellNode canUpdateToViewModel:].YESfrom that, we keep using the same node, and update the view model on a background thread, same as we'd allocate a new node.reloadItemsAtIndexPaths:call to the UICollectionView, which may mean a flash for animated updates. Suppressing this call is something we do later.