Fix double-load issue with ASCollectionNode #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
commented
Jun 19, 2017
Source/ASCollectionNode.mm
Outdated
| { | ||
| [self.view reloadDataImmediately]; | ||
| [self.view relayoutItems]; |
There was a problem hiding this comment.
I swapped the order of these two methods to group the reloadData* methods together.
Adlai-Holler
commented
Jun 19, 2017
| } completion:^(BOOL finished){ | ||
| if (completion) { | ||
| completion(); | ||
| } |
There was a problem hiding this comment.
Implementation copied from ASCollectionView.
nguyenhuy
approved these changes
Jun 19, 2017
Source/ASCollectionNode.mm
Outdated
| { | ||
| [self.view reloadDataImmediately]; | ||
| [self.view relayoutItems]; |
There was a problem hiding this comment.
I know the original code doesn't assert main thread and check if this node is loaded, should we do these now?
| @@ -752,7 +754,8 @@ - (void)testThatSectionContextsAreCorrectAfterReloadData | |||
| updateValidationTestPrologue | |||
|
|
|||
| del.sectionGeneration++; | |||
| [cv reloadDataImmediately]; | |||
| [cn reloadData]; | |||
| [cn waitUntilAllUpdatesAreCommitted]; | |||
There was a problem hiding this comment.
No because it's deprecated.
| UIWindow *window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];\ | ||
| [window makeKeyAndVisible]; \ | ||
| window.rootViewController = testController;\ | ||
| \ | ||
| [testController.collectionView reloadDataImmediately];\ | ||
| [cn reloadData];\ | ||
| [cn waitUntilAllUpdatesAreCommitted]; \ |
There was a problem hiding this comment.
Same here, [cn reloadDataImmediately]?
There was a problem hiding this comment.
No because it's deprecated.
| @@ -259,7 +259,8 @@ - (void)testSelection | |||
| [window setRootViewController:testController]; | |||
| [window makeKeyAndVisible]; | |||
|
|
|||
| [testController.collectionView reloadDataImmediately]; | |||
| [testController.collectionNode reloadData]; | |||
| [testController.collectionNode waitUntilAllUpdatesAreCommitted]; | |||
There was a problem hiding this comment.
Shouldn't we call reloadDataImmediately directly?
There was a problem hiding this comment.
No because it's deprecated.
garrettmoon
pushed a commit
that referenced
this pull request
Jun 30, 2017
* Fix double-reload issue with ASCollectionNode * Add a message to the change pile * Fix some license headers * Address feedback
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Fix double-reload issue with ASCollectionNode * Add a message to the change pile * Fix some license headers * Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #351
[ASCollectionView reloadData*]unavailable, not deprecated. This is breaking API but the methods have been deprecated for going on 7 months.reloadDataon a view that has been cast to(UICollectionView *)but it just won't do what they expect. Nothing will actually change.[ASCollectionNode reloadData*]to do the real work.