Fix for Video Table Example Building #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
previously requested changes
Jun 24, 2017
| _textNode.flexShrink = 1.0; | ||
|
|
||
| [_videoNode.style setWidth:ASDimensionMake(videoNodeSize.width)]; | ||
| [_videoNode.style setHeight:ASDimensionMake(videoNodeSize.height)]; |
There was a problem hiding this comment.
Can you please change that to: _videoNode.style.preferredSize = videoNodeSize;
|
@maicki Adjusted that. 👍 Used it previously but thought it wasn't working as the videos weren't all loading in. Adjusted the URLs for the two which no longer exist to use one from ASDKTube. |
nguyenhuy
requested changes
Jun 24, 2017
| _videoNode.size = ASRelativeSizeRangeMakeWithExactCGSize(videoNodeSize); | ||
| _textNode.flexShrink = 1.0; | ||
|
|
||
| [_videoNode.style setHeight:ASDimensionMake(videoNodeSize.height)]; |
There was a problem hiding this comment.
There is no need to setHeight separately. Please remove this line.
There was a problem hiding this comment.
My bad, left that in. Needed some coffee ☕️
| break; | ||
|
|
||
| case 1: | ||
| // Construct the video node directly from the .mp4 URL | ||
| _videoNode = [[ASVideoNode alloc] init]; | ||
| _videoNode.asset = [AVAsset assetWithURL:[NSURL URLWithString:@"https://files.parsetfss.com/8a8a3b0c-619e-4e4d-b1d5-1b5ba9bf2b42/tfss-753fe655-86bb-46da-89b7-aa59c60e49c0-niccage.mp4"]]; | ||
| _videoNode.asset = [AVAsset assetWithURL:[NSURL URLWithString:@"https://www.w3schools.com/html/mov_bbb.mp4"]]; |
There was a problem hiding this comment.
Please extract the URL to a constant.
|
Also, please fix Danger's warning(s). Thanks! |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Fix for Video Table Example Building * Adjust to use setPreferredSize * Change video URLs out for ones that still exist * Update header * Forgot to remove setHeight: * Extract URLs * Update license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix up the Video Table Example where size is not found. Reported in Slack.