Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Improve description of synchronous concurrency with screenshot and video link. #406

Merged
merged 2 commits into from
Jul 1, 2017

Conversation

appleguy
Copy link
Member

@appleguy appleguy commented Jul 1, 2017

No description provided.

@appleguy appleguy requested review from garrettmoon and nguyenhuy July 1, 2017 05:33
@appleguy
Copy link
Member Author

appleguy commented Jul 1, 2017

@garrettmoon @nguyenhuy is it normal that the preview of the markdown shows a broken image link? I went to this branch (on the Code tab) and navigated to the edited .md file, and did Preview there.

I modeled the path to the image based on a working page, so I'm not sure if maybe this has to land before it can preview.

@appleguy appleguy changed the title Add screenshot for synchronous concurrency description [Documentation] Improve description of synchronous concurrency with screenshot and video link. Jul 1, 2017
@nguyenhuy
Copy link
Member

Yeah, since it's an relative path, it'll be fine once merged.

@nguyenhuy nguyenhuy merged commit 5e288c5 into master Jul 1, 2017
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…creenshot and video link. (TextureGroup#406)

* Add screenshot for synchronous concurrency description

* Include reference to new image, improve text of synchronous concurrency doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants