Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASCollectionView] Small improvements #407

Merged
merged 10 commits into from
Jul 6, 2017
Merged

[ASCollectionView] Small improvements #407

merged 10 commits into from
Jul 6, 2017

Commits on Jul 6, 2017

  1. Minor refactors in ASCollectionView and its private cell classes 

    - `_ASCollectionReusableView` and `_ASCollectionViewCell` no longer expose getters for their collection element and cell node properties. This is to make sure that clients can only obtain elements from the visible map which is always the source of truth.
- Since the map can return `nil` for an element request, it's much safer to check and avoid adding/removing a nil pointer to an `NSArray`.
- Since we use a special way to check whether an object of kind of `_ASCollectionViewCell` or `_ASCollectionReusableView`, based on the assumption that these classes are subclass restricted, I added cast-or-return  macros in the header files, closer to where the restrictions are declared.
    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    fe9e626 View commit details
    Browse the repository at this point in the history

  2. Add ASDynamicCastStrict

    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    e32ad6d View commit details
    Browse the repository at this point in the history

  3. Add element and node properties back to _ASCollectionReusableView and… 

    … _ASCollectionViewCell
    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    33a9c4d View commit details
    Browse the repository at this point in the history

  4. Assert unexpected nil elements

    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    bd31b05 View commit details
    Browse the repository at this point in the history

  5. Always mark an element visible even if it is backed by an UIKit / non… 

    …-_ASCollection* view
    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    2bcf410 View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    8b0dfe0 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary changes

    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    e384428 View commit details
    Browse the repository at this point in the history

  8. Dump mistakes

    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    4b9f906 View commit details
    Browse the repository at this point in the history

  9. Update CHANGELOG

    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    c5f8754 View commit details
    Browse the repository at this point in the history

  10. Can't track visibility of elements backed by non-_AS views

    @nguyenhuy
    nguyenhuy committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    8726c98 View commit details
    Browse the repository at this point in the history