Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASElementMap] Fix indexPath's section or item is actually negative #trivial #457

Merged
merged 2 commits into from
Sep 18, 2017
Merged

[ASElementMap] Fix indexPath's section or item is actually negative #trivial #457

merged 2 commits into from
Sep 18, 2017

Conversation

Anyewuya
Copy link
Contributor

when indexPath's section or item is actually negative that is invalid。

nguyenhuy
nguyenhuy reviewed Aug 2, 2017
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anyewuya Sorry for the late review. Could you include a crash report or a description for why/how the section is negative?

nguyenhuy
nguyenhuy approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking again, since those values are of type NSInteger and are passed in by clients, it doesn't hurt to check and make sure they're indeed positive. Thanks for contributing, @Anyewuya!

@ghost
Copy link

ghost commented Sep 18, 2017

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@nguyenhuy nguyenhuy changed the title [ASElementMap] Fix indexPath's section or item is actually negative. [ASElementMap] Fix indexPath's section or item is actually negative #trivial Sep 18, 2017
@nguyenhuy nguyenhuy merged commit d4846dc into TextureGroup:master Sep 18, 2017
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
@Anyewuya @bernieperez
[ASElementMap] Fix indexPath's section or item is actually negative #…
7f46613 
…trivial (TextureGroup#457)

* [ASElementMap] Fix indexPath's section or item is actually negative.

* Small code style changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

@maicki maicki maicki approved these changes

Assignees
No one assigned
Labels
Close if no reply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anyewuya @maicki @nguyenhuy