Update scroll-node.md #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding the last sentence: “As you can see, the `scrollNode`'s underlying view is a `ASScrollNode`.”: 1. I think that `ASScrollNode` should be replaced with `UIScrollView`. 2. But — not sure how can it be seen from this example...
maicki
previously requested changes
Jul 31, 2017
There was a problem hiding this comment.
Hey @oferRounds !
I think we should just remove this sentence in there completely. As you point out, it does not really makes sense in this case and it seems it's some leftover from previous edits.
Thanks for working on that!
Removed the last sentence, as it did not make sense, and probably left there from previous editions.
|
@maicki agreed, done! |
garrettmoon
approved these changes
Jul 31, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Update scroll-node.md Regarding the last sentence: “As you can see, the `scrollNode`'s underlying view is a `ASScrollNode`.”: 1. I think that `ASScrollNode` should be replaced with `UIScrollView`. 2. But — not sure how can it be seen from this example... * Update scroll-node.md Removed the last sentence, as it did not make sense, and probably left there from previous editions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the last sentence: “As you can see, the
scrollNode's underlying view is aASScrollNode.”:ASScrollNodeshould be replaced withUIScrollView.